Skip to content

[Validator] Support for parsing PHP constants in yaml loader #23039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2017
Merged

[Validator] Support for parsing PHP constants in yaml loader #23039

merged 1 commit into from
Jul 3, 2017

Conversation

mimol91
Copy link

@mimol91 mimol91 commented Jun 2, 2017 •
edited by nicolas-grekas
Loading

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Yaml components supports PHP constants. It would be great if we could use it also in validator component.

@mimol91 mimol91 changed the title Support for parsing PHP constants in yaml loader [Validator] Support for parsing PHP constants in yaml loader Jun 2, 2017
@mimol91 mimol91 force-pushed the validator-Yaml-ConstSupport branch 3 times, most recently from 5a5ea8d to f5918fe Compare June 2, 2017 16:57
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 3, 2017 •
edited
Loading

Hi @mimol91, congrats for your first PR!
Can you please rebase on branch 3.4, then change the base branch here on github (click on "Edit" near the title of the PR)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 3, 2017
@mimol91 mimol91 force-pushed the validator-Yaml-ConstSupport branch from f5918fe to 1d13744 Compare June 3, 2017 17:54
@mimol91 mimol91 changed the base branch from 3.2 to 3.4 June 3, 2017 17:55
@mimol91 mimol91 force-pushed the validator-Yaml-ConstSupport branch 2 times, most recently from 2028461 to 2d708f2 Compare June 3, 2017 17:59
@mimol91
Copy link
Author

mimol91 commented Jun 3, 2017

I am not sure about tests, because they are related to Yaml component. Should I remove them?

@mimol91 mimol91 force-pushed the validator-Yaml-ConstSupport branch from 2d708f2 to 37afeea Compare June 3, 2017 20:41
@fabpot
Copy link
Member

fabpot commented Jul 3, 2017

Thank you @mimol91.

@fabpot fabpot merged commit 37afeea into symfony:3.4 Jul 3, 2017
fabpot added a commit that referenced this pull request Jul 3, 2017
@fabpot
feature #23039 [Validator] Support for parsing PHP constants in yaml …
ccfc4da 
…loader (mimol91)

This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Support for parsing PHP constants in yaml loader

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        |  -

Yaml components supports PHP constants. It would be great if we could use it also in validator component.

Commits
-------

37afeea Support for parsing PHP constants in yaml loader
@javiereguiluz javiereguiluz mentioned this pull request Jul 16, 2017
Closed
2 tasks
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Feature Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
5 participants
@mimol91 @nicolas-grekas @fabpot @xabbuh @carsonbot