Automatically enable the routing annotation loader #23044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6cee255 to
f7b9a80
Compare
fabpot
requested changes
Jun 6, 2017
| */ | ||
| protected function getDefaultRouteName(\ReflectionClass $class, \ReflectionMethod $method) | ||
| { | ||
| $routeName = parent::getDefaultRouteName($class, $method); |
Sensio's loaders take precedence over these new loaders because of their priority. |
f7b9a80 to
c2f796f
Compare
fabpot
approved these changes
Jun 9, 2017
|
Thank you @GuilhemN. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2017
…ilhemN) This PR was merged into the 3.4 branch. Discussion ---------- Automatically enable the routing annotation loader | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | there's probably one but I didn't find it | License | MIT | Doc PR | Thanks to fqcn services, most of the time, we don't need the SensioFrameworkExtraBundle to use `@Route`. So I suggest to automatically enable it when annotations are enabled. This way we could simplify https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/3.3/etc/routing.yaml#L5. Note: I added priority support for routing loaders to make sure sensio loaders are executed before ours. Commits ------- c2f796f Automatically enable the routing annotation loader
This was referenced Jun 10, 2017
fabpot
added a commit
that referenced
this pull request
Jun 12, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Fix colliding service ids | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Rereading #23044, I realized that `routing.loader.directory` is already used, so it should be changed. Commits ------- a4d799a [FrameworkBundle] Fix colliding service ids
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 4, 2017
…dle since 3.4 (GuilhemN) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #8016). Discussion ---------- [Routing] `@Route` is usable without SensioFrameworkBundle since 3.4 Since symfony/symfony#23044, annotation routes are supported by the framework bundle. So I think we should push using the annotation of the Routing component instead of the one of SensioFrameworkExtraBundle. Commits ------- c0e466a [Routing] is usable without SensioFrameworkBundle since 3.4
This was referenced Oct 18, 2017
Merged
Merged
fabpot
added a commit
to sensiolabs/SensioFrameworkExtraBundle
that referenced
this pull request
Feb 24, 2018
…favor of Symfony Core (Tobion) This PR was merged into the 5.1.x-dev branch. Discussion ---------- Deprecate routing annotation of FrameworkExtraBundle in favor of Symfony Core Since symfony/symfony#23044 routing annotation is part of Symfony Core. The only extra features that the routing annotation from SensioFrameworkExtraBundle has are - service config for `@Route` which we don't need anymore - Either you use class-named services, then you don't need the "service" property at all. - Or you don't use class-named services. In this case the better solution to me, is for people to create a alias in the container from the controller class to to service id instead of specifying the service id in the routing. Then you're set as well and that is already common practice with autowiring. - `@Method` does not provide real value as people agree in symfony/symfony#25103 This resolves symfony/symfony#25103 Commits ------- 444683c Deprecate routing annotation of FrameworkExtraBundle in favor of Symfony Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to fqcn services, most of the time, we don't need the SensioFrameworkExtraBundle to use
@Route.So I suggest to automatically enable it when annotations are enabled. This way we could simplify https://github.com/symfony/recipes/blob/master/symfony/framework-bundle/3.3/etc/routing.yaml#L5.
Note: I added priority support for routing loaders to make sure sensio loaders are executed before ours.