-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] Dont set pre-defined esi/ssi services #23088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Complex topic :) |
👍 for deprecation the esi/ssi defintions (and revert adding About
Is this needed, either setting them as request attribute or service =/ I believe Not sure we need to pass anything here =/ edit: |
@ro0NL right, let's try this way. |
Hm.. we can have 2 So we cant deprecate the service really, but we should check for a esi/ssi surrogate from the kernel first. Let me try :) |
Something like this :) |
Thank you @ro0NL. |
…o0NL) This PR was squashed before being merged into the 3.3 branch (closes #23088). Discussion ---------- [FrameworkBundle] Dont set pre-defined esi/ssi services | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | not sure | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #23080 | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> It fixes the issue, but im not sure what's expected if you dont use http cache (solely enabled ssi/esi in config). Before the services were initialized, now they are synthetic as http cache sets them, but thats optional =/ Commits ------- 8c26aab [FrameworkBundle] Dont set pre-defined esi/ssi services
It fixes the issue, but im not sure what's expected if you dont use http cache (solely enabled ssi/esi in config). Before the services were initialized, now they are synthetic as http cache sets them, but thats optional =/