Skip to content

[SecurityBundle] Made 2 service aliases private #23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2017
Merged

[SecurityBundle] Made 2 service aliases private #23090

merged 1 commit into from
Jun 9, 2017

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? no
Fixed tickets -
License MIT
Doc PR -

We missed making them private :(
Is it too late to fix that?

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Jun 7, 2017
@Hanmac
Copy link
Contributor

Hanmac commented Jun 7, 2017 •
edited
Loading

i don't like it to make security.authorization_checker private.
i have many bundles in my projects (like Sonata, or Sensio) which does use this service for the isGranted check. what else should be used for that?

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Jun 7, 2017 •
edited
Loading

@Hanmac this is making
Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface
and
Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface
private,
it doesn't change anything when using security.authorization_checker.

@stof
Copy link
Member

stof commented Jun 7, 2017

I'm 👍 for this, as we never documented these aliases (they are there for autowiring purpose only)

@fabpot
Copy link
Member

fabpot commented Jun 9, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 4442c63 into symfony:3.3 Jun 9, 2017
fabpot added a commit that referenced this pull request Jun 9, 2017
@fabpot
bug #23090 [SecurityBundle] Made 2 service aliases private (nicolas-g…
b376eca 
…rekas)

This PR was merged into the 3.3 branch.

Discussion
----------

[SecurityBundle] Made 2 service aliases private

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

We missed making them private :(
Is it too late to fix that?

Commits
-------

4442c63 [SecurityBundle] Made 2 service aliases private
@fabpot fabpot mentioned this pull request Jul 4, 2017
Merged
@nicolas-grekas nicolas-grekas deleted the priv-alias branch July 10, 2017 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
BC Break Bug SecurityBundle Status: Needs Review
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
7 participants
@nicolas-grekas @Hanmac @stof @fabpot @xabbuh @chalasr @carsonbot