[PropertyAccess] Do not silence TypeErrors from client code. #23100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theofidry
reviewed
Jun 8, 2017
| @@ -244,6 +244,9 @@ public function setValue(&$objectOrArray, $propertyPath, $value) | |||
| } | |||
| } catch (\TypeError $e) { | |||
| self::throwInvalidArgumentException($e->getMessage(), $e->getTrace(), 0); | |||
|
|
|||
| // It wasn't thrown in this class so rethrow it | |||
| throw $e; | |||
There was a problem hiding this comment.
shouldn't be this done in throwInvalidArgumentException instead?
There was a problem hiding this comment.
no, because it is used elsewhere too
There was a problem hiding this comment.
shouldn't the other place also throw?
There was a problem hiding this comment.
the other place is error handler callback for PHP 5, there is no exception to rethrow, and errors are passed correctly to the original handler (here)
dunglas
approved these changes
Jun 14, 2017
|
Thank you @tsufeki. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
…e. (tsufeki)
This PR was merged into the 3.2 branch.
Discussion
----------
[PropertyAccess] Do not silence TypeErrors from client code.
| Q | A
| ------------- | ---
| Branch? | 3.2
| Bug fix? | yes
| New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks? | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Fixes TypeError silencing in `setValue()` when said error is thrown inside setter/adder/etc.
An example is given in the included test, but more real-life story is botched accessors for a many-to-one association on a Doctrine entity:
```php
class B {
function setA(A $a) { ... } // forgotten "= null" here
}
class A {
function removeB(B $b) {
if ($this->bs->contains($b)) {
$this->bs->removeElement($b);
$b->setA(null); // TypeError thrown
}
return $this;
}
}
```
No error is shown to the user, even though removing doesn't work.
This bug is not present in 2.7 & 2.8.
Commits
-------
45b961d [PropertyAccess] Do not silence TypeErrors from client code.
|
@fabpot I think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes TypeError silencing in
setValue()when said error is thrown inside setter/adder/etc.An example is given in the included test, but more real-life story is botched accessors for a many-to-one association on a Doctrine entity:
No error is shown to the user, even though removing doesn't work.
This bug is not present in 2.7 & 2.8.