[Yaml] Remove line number in deprecation notices #23108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
stof
reviewed
Jun 8, 2017
| @@ -237,8 +237,8 @@ private function doParse($value, $flags) | |||
| } | |||
|
|
|||
| if (!(Yaml::PARSE_KEYS_AS_STRINGS & $flags) && !is_string($key)) { | |||
There was a problem hiding this comment.
integer keys must be allowed, not only string keys (PHP array support integers). Can you also fix it (there is a PR fixing it currently, but together with other changes and so targetting 3.4)
f2a7b42 to
f82b618
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 9, 2017
…grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Yaml] Remove line number in deprecation notices | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While moving an app to 3.3, I noticed that my deprecation log is full of deprecation notices that differ only by some line number, but don't tell which file is concerned. This makes the line number useless, and just prevents aggregation.  Commits ------- f82b618 [Yaml] Remove line number in deprecation notices
|
Although I 👍 with the MR, I think the line numbers would be really helpful. Maybe in a more verbose |
|
@rvanlaak |
|
An without the file, line numbers are useless... |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Sep 29, 2017
…ecation (xabbuh) This PR was merged into the 3.3 branch. Discussion ---------- [DependencyInjection] include file and line number in deprecation | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | In #23108 we removed line numbers from deprecation messages created by the YAML parser because those numbers were quite useless without the file being parsed. I suggest to revert this change and add the file being parsed to the deprecation message. Commits ------- cf03552 include file and line number in deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While moving an app to 3.3, I noticed that my deprecation log is full of deprecation notices that differ only by some line number, but don't tell which file is concerned.
This makes the line number useless, and just prevents aggregation.