[Routing] Revert the change in [#b42018] with respect to Routing/Route.php #23121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e it breaks BC. Refers to symfony#21090 and symfony#23109
xabbuh
approved these changes
Jun 10, 2017
fabpot
requested changes
Jun 10, 2017
|
As requested, I have amended the comment in the pull request and added a test. Let me know if you'd like anything else. |
fabpot
requested changes
Jun 12, 2017
| @@ -221,6 +221,21 @@ public function testSerializeWhenCompiled() | |||
| } | |||
|
|
|||
| /** | |||
| * Tests that the compiled version does not fail when the Route refers to | |||
| * arbitrary classes. | |||
There was a problem hiding this comment.
Does not seem to be why we are doing it. We only want to ensure that the compiled route can be different from CompiledRoute, not that you can use any object on the route definition, which is not supported.
fabpot
approved these changes
Jun 13, 2017
|
|
||
| class CustomRouteCompiler extends RouteCompiler | ||
| { | ||
| /** |
| try { | ||
| $unserialized = unserialize($serialized); | ||
| $this->assertInstanceOf('\Symfony\Component\Routing\Tests\Fixtures\CustomCompiledRoute', $unserialized->compile(), 'the unserialized route compiled successfully'); | ||
| } catch (\Exception $except) { |
|
Thank you @Gribnif. |
fabpot
added a commit
that referenced
this pull request
Jun 13, 2017
…outing/Route.php (Dan Wilga) This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #23121). Discussion ---------- [Routing] Revert the change in [#b42018] with respect to Routing/Route.php | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21090 #23109 | License | MIT | Doc PR | ...because it breaks BC with third-party code which, for instance, might use a subclass of CompiledRoute within the options portion of the Route. Refers to #21090 and #23109 Commits ------- f09893b [Routing] Revert the change in [#b42018] with respect to Routing/Route.php
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...because it breaks BC with third-party code which, for instance, might use a subclass of CompiledRoute within the options portion of the Route. Refers to #21090 and #23109