[FrameworkBundle] drop hard dependency on the Stopwatch component #23148
Conversation
xabbuh
commented
Jun 12, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | related to symfony/flex#14 |
| License | MIT |
| Doc PR |
|
does TwigBundle works fine for the Stopwatch extension if the service is not always available anymore ? |
This PR was merged into the master branch. Discussion ---------- add dependency on the Stopwatch component This is the counterpart of symfony/symfony#23148. Using the profiler without the Stopwatch component makes it lack a lot of useful information. However, in production you will probably not need it all. Thus, I suggest to require the component in the profiler pack to allow the FrameworkBundle to drop the dependency and thus decreasing the required deps for the production environment. Commits ------- 06d5b5b add dependency on the Stopwatch component
|
Good question, I did not check what's happing if the |
|
@xabbuh well, currently, the debug.stopwatch service is always present. So we clearly need to check the impact of this change |
|
@stof all usage in Symfony uses |
@fabpot that's not true. This service was defined in |
|
However, it won't change anything for fullstack users |
|
@stof indeed, I thought I remembered it being defined in |
|
Thank you @xabbuh. |
…h component (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] drop hard dependency on the Stopwatch component | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | related to symfony/flex#14 | License | MIT | Doc PR | Commits ------- 8d70ca0 drop hard dependency on the Stopwatch component
|
FYI, I have checked the code of the classes where |
…pwatch (stof) This PR was merged into the 3.4 branch. Discussion ---------- Fix the usage of FrameworkBundle in debug mode without Stopwatch | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a #23148 removed the loading of the debug.xml file when Stopwatch is not installed. While all services defined in it are related to Stopwatch, the parameter was not (it is related to dumping the debug container in the compiler pass), which was breaking the usage of the bundle in debug mode without Stopwatch (exception triggered in the compiler pass) Commits ------- 2ea26c1 Fix the usage of FrameworkBundle in debug mode without Stopwatch