[WebProfilerBundle] Sticky ajax window #23154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure about this because it introduces a different behavior in the toolbar depending on the panel the user clicks. |
|
Well.. currently it's the only block (by default) that has no click handler (ie. is not a link). So it already behaves different, but in a more frustrating way :) it's truly convenient :)) |
nicolas-grekas
approved these changes
Jun 14, 2017
There was a problem hiding this comment.
👍 as explained by @ro0NL the "click" action should do something useful, here it is :)
stof
reviewed
Jun 14, 2017
| .sf-toolbar-block:hover .sf-toolbar-icon { | ||
| .sf-toolbar-block:hover .sf-toolbar-icon, | ||
| .sf-toolbar-block.hover .sf-toolbar-icon | ||
| { |
There was a problem hiding this comment.
this curly brace should stay on previous line for consistency with all other rules
|
i think we should do this for all blocks that are not linking btw =/ (ie. |
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
This PR was squashed before being merged into the 3.4 branch (closes #23154). Discussion ---------- [WebProfilerBundle] Sticky ajax window | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23125 | License | MIT | Doc PR | - This toggles the ajax toolbar block being sticky on click. I find it quite useful in heavy ajax apps :) Not sure the state needs to be persisted in local storage or so, could be done :) however for our app all the navigating happens via react router, hence no real need for us to persist it between requests. Commits ------- b92929b [WebProfilerBundle] Sticky ajax window
nicolas-grekas
added a commit
that referenced
this pull request
Sep 18, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [WebProfiler] Fix z-index for sticky ajax window | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes/no | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> Forgotten in #23154 Before  After  In case you hover the time panel. Commits ------- 081c1e4 [WebProfiler] Fix z-index for pinned AJAX block
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This toggles the ajax toolbar block being sticky on click. I find it quite useful in heavy ajax apps :)
Not sure the state needs to be persisted in local storage or so, could be done :) however for our app all the navigating happens via react router, hence no real need for us to persist it between requests.