Skip to content

[Yaml] Fix linting yaml with constants as keys #23171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2017
Merged

[Yaml] Fix linting yaml with constants as keys #23171

merged 1 commit into from
Jun 14, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jun 13, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23167
License MIT
Doc PR n/a

@chalasr chalasr force-pushed the yaml-lint-string-keys branch 3 times, most recently from c57965d to 7bba48d Compare June 13, 2017 21:04
@chalasr chalasr force-pushed the yaml-lint-string-keys branch from 7bba48d to 55a8d35 Compare June 13, 2017 21:05
@chalasr chalasr mentioned this pull request Jun 13, 2017
Closed
@fabpot
Copy link
Member

fabpot commented Jun 14, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 55a8d35 into symfony:3.3 Jun 14, 2017
fabpot added a commit that referenced this pull request Jun 14, 2017
@fabpot
bug #23171 [Yaml] Fix linting yaml with constants as keys (chalasr)
748a999 
This PR was merged into the 3.3 branch.

Discussion
----------

[Yaml] Fix linting yaml with constants as keys

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23167
| License       | MIT
| Doc PR        | n/a

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the 3.4,
  legacy code removals go to the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

55a8d35 [Yaml] Fix linting yaml with constants as keys
@chalasr chalasr deleted the yaml-lint-string-keys branch June 14, 2017 07:39
@fabpot fabpot mentioned this pull request Jul 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Needs Review Yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @fabpot @xabbuh @carsonbot