[VarDumper] fixes #23176
Merged
[VarDumper] fixes #23176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jun 14, 2017
fabpot
approved these changes
Jun 14, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jun 14, 2017
This PR was merged into the 2.7 branch. Discussion ---------- [VarDumper] fixes | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23115 and #23151 (hopefully) | License | MIT | Doc PR | - it looks like stream_context_get_params can return false (looking at php-src and #23151) and doing a foreach on SplObjectStorage changes its internal iterator state. Commits ------- d7238c9 [VarDumper] fixes
|
We regularly merge branches up to master. Thus, changes done in 2.7 will also land in all her still maintained releases. |
|
Okay thanks for the explanation :) |
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
fabpot
added a commit
that referenced
this pull request
Apr 22, 2018
This PR was squashed before being merged into the 2.7 branch (closes #26999). Discussion ---------- [VarDumper] Fix dumping of SplObjectStorage | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is a bug fix for dumping instances of `SplObjectStorage`. The bug was introduced in #23176, by fixing that the internal pointer was changed upon dumping. I added tests for both issues. Commits ------- b2ac6b6 [VarDumper] Fix dumping of SplObjectStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it looks like stream_context_get_params can return false (looking at php-src and #23151)
and doing a foreach on SplObjectStorage changes its internal iterator state.