Skip to content

[FrameworkBundle] Allow .yaml file extension everywhere #23207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2017
Merged

[FrameworkBundle] Allow .yaml file extension everywhere #23207

merged 1 commit into from
Jun 16, 2017

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23205
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request Jun 16, 2017
Closed
stof
stof reviewed Jun 16, 2017
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php Outdated
if ($container->fileExists($file = $dirname.'/Resources/config/validation.yml', false)) {
if (
$container->fileExists($file = $dirname.'/Resources/config/validation.yml', false) ||
$container->fileExists($file = $dirname.'/Resources/config/validation.yaml', false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if both exists ?

Copy link
Contributor Author

@ogizanagi ogizanagi Jun 16, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .yml file will take precedence (actually it'll probably better to do the reverse).
Do you think it's an issue?

@ogizanagi ogizanagi changed the title [FrameworkBundle] Allow yaml extensions everywhere [FrameworkBundle] Allow .yaml file extension everywhere Jun 16, 2017
fabpot
fabpot approved these changes Jun 16, 2017
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having .yml first is more BC, so LGTM

@fabpot
Copy link
Member

fabpot commented Jun 16, 2017

Thank you @ogizanagi.

@fabpot fabpot merged commit 2940bb0 into symfony:3.4 Jun 16, 2017
fabpot added a commit that referenced this pull request Jun 16, 2017
@fabpot
feature #23207 [FrameworkBundle] Allow .yaml file extension everywher…
6727a26 
…e (ogizanagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Allow .yaml file extension everywhere

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | yes <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #23205 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

2940bb0 [FrameworkBundle] Allow .yaml file extension everywhere
@ogizanagi ogizanagi deleted the feature/mapping_support_yaml_ext branch June 16, 2017 19:00
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogizanagi @fabpot @stof @carsonbot