[WebProfilerBundle] Add configuration entry to disable JS confirm dialog on error #23251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logs when toolbar can't be loaded
f5b3743 to
1608931
Compare
|
I agree that this is annoying ... but we always prefer to not add more config options. What if we use this behavior instead?
|
|
Sounds way better 👍 should this be done in a new PR? I'll see what I can do but I can't tell when I'll find the time to implement it. |
|
@javiereguiluz's sounds great! That could be done in this PR or another. In any case, if you don't have time to work on this soon, I'd prefer that we close this PR and open an issue to not loose this conversation. Thanks. |
|
I'll try to come up with another PR soon. For now closing this in favor of #23264. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to disable the JS confirmation dialog ("Do you want to open the profiler?") if loading of the profiler toolbar fails. In certain environments with many logs/db queries the profiler might fail regularly and having the dialog popping up on every request makes debugging tedious. With this change you can disable the confirmation - the toolbar will just silently fail instead of showing the dialog: