[Form][TwigBridge] render hidden _method field in form_rest() #23254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jun 21, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #14261 |
| License | MIT |
| Doc PR |
fabpot
approved these changes
Jun 21, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jun 21, 2017
…t() (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [Form][TwigBridge] render hidden _method field in form_rest() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14261 | License | MIT | Doc PR | Commits ------- 0ee3f57 render hidden _method field in form_rest()
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
ogizanagi
added a commit
that referenced
this pull request
Jul 25, 2017
… a child form (fmarchalemisys) This PR was squashed before being merged into the 2.7 branch (closes #23649). Discussion ---------- [Form][TwigBridge] Don't render _method in form_rest() for a child form The hidden `_method` must only be generated if the form is the top most form. Always generating the hidden `_method` breaks forms using the POST method when they have children using the PUT method. If `_method` is generated for such a child form, it overrides the parent method and the form fails to validate. See issue #23254 | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #14261 | License | MIT | Doc PR | Commits ------- 973b2d3 [Form][TwigBridge] Don't render _method in form_rest() for a child form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.