Don't call count on non countable object #23279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jun 24, 2017
xabbuh
approved these changes
Jun 24, 2017
fabpot
approved these changes
Jun 24, 2017
|
Thank you @pierredup. |
fabpot
added a commit
that referenced
this pull request
Jun 24, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Don't call count on non countable object | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | From PHP 7.2, calling `count` on a non-countable object will emit a warning (https://wiki.php.net/rfc/counting_non_countables). Based on the current test suit, this is the only place where I found this warning Commits ------- 635bccd Dont call count on non countable object
This was referenced Jul 3, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PHP 7.2, calling
counton a non-countable object will emit a warning (https://wiki.php.net/rfc/counting_non_countables).Based on the current test suit, this is the only place where I found this warning