[Yaml] deprecate the !str tag #23288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Jun 24, 2017
55c34cb to
a6b5571
Compare
The tag specified in the YAML spec is actually !!str.
a6b5571 to
976b93a
Compare
GuilhemN
reviewed
Jun 25, 2017
| return (string) substr($scalar, 5); | ||
| case 0 === strpos($scalar, '!!str '): | ||
| return (string) substr($scalar, 6); |
There was a problem hiding this comment.
While doing this, can't we use parseScalar here?
There was a problem hiding this comment.
Maybe it's better to do that in a separate PR to not mix too many things in the same PR.
There was a problem hiding this comment.
if we use parseScalar, we may end up parsing the value as a YAML timestamp for instance, which will break the usage of the tag (see not-date: !!str 2002-04-28 in the tests for instance)
There was a problem hiding this comment.
Fortunately parseScalar has a $evaluate argument :)
javiereguiluz
approved these changes
Jun 25, 2017
GuilhemN
approved these changes
Jun 25, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Yaml] deprecate the !str tag | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The tag specified in the YAML spec is actually !!str. Commits ------- 976b93a [Yaml] deprecate the !str tag
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag specified in the YAML spec is actually !!str.