[Workflow] Added more events to the announce function #23299
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
approved these changes
Jun 25, 2017
ostrolucky
suggested changes
Jun 25, 2017
xabbuh
approved these changes
Jun 26, 2017
|
Thank you @ostrolucky for your review. I will send a PR to the docs. Also, we need to make sure we do not "announce" before the guard events. The guard events may block the transition. |
This reverts commit 30728d9.
|
Sorry, I was wrong in my last comment and commit. I reverted it, the PR is now unchanged since you reviewed it. I made a small PR to the docs to address the issue @ostrolucky highlighted. |
|
Thanks for fixing this bug @Nyholm. |
lyrixx
added a commit
that referenced
this pull request
Jun 26, 2017
…olm) This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #23299). Discussion ---------- [Workflow] Added more events to the announce function | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes/no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23275 | License | MIT | Doc PR | #8087 This PR will fix #23275 The documentation states that we dispatch events `workflow.announce` and `workflow.[name].announce`. It was me who wrongly added it to the docs... sorry about that. We could either: Change the docs or add these events. I choose to add these event to the source since the same events are dispatched for "guard", "leave", "transition", "enter" and "entered". Commits ------- c5042f3 [Workflow] Added more events to the announce function
|
I merged this PR in the 3.2 branch instead of master. |
|
Thank you for merging. |
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 4, 2017
This PR was submitted for the 3.3 branch but it was merged into the 3.2 branch instead (closes #8087). Discussion ---------- [Workflow] Updated language for annouce event Related to symfony/symfony#23299 Commits ------- 9b6dce4 Updated language for annouce event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will fix #23275
The documentation states that we dispatch events
workflow.announceandworkflow.[name].announce. It was me who wrongly added it to the docs... sorry about that.We could either: Change the docs or add these events. I choose to add these event to the source since the same events are dispatched for "guard", "leave", "transition", "enter" and "entered".