Skip to content

[DI] Remove an unused property #23300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2017
Merged

[DI] Remove an unused property #23300

merged 1 commit into from
Jul 4, 2017

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jun 25, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@ro0NL
Copy link
Contributor

ro0NL commented Jun 26, 2017 •
edited
Loading

Could you check https://github.com/symfony/symfony/pull/22811/files#r118755708 it's still used :)

@nicolas-grekas
Copy link
Member

@dunglas can you patch that line in this PR also, as spotted by @ro0NL above?

@nicolas-grekas nicolas-grekas added this to the 4.0 milestone Jul 3, 2017
@dunglas dunglas force-pushed the container_useless_prop branch 2 times, most recently from 3f70279 to a618073 Compare July 3, 2017 21:52
@dunglas dunglas force-pushed the container_useless_prop branch from a618073 to e5bb2bc Compare July 3, 2017 21:53
@dunglas
Copy link
Member Author

dunglas commented Jul 3, 2017

@nicolas-grekas done

@fabpot
Copy link
Member

fabpot commented Jul 4, 2017

Thank you @dunglas.

@fabpot fabpot merged commit e5bb2bc into symfony:master Jul 4, 2017
fabpot added a commit that referenced this pull request Jul 4, 2017
@fabpot
minor #23300 [DI] Remove an unused property (dunglas)
06e21f7 
This PR was merged into the 4.0-dev branch.

Discussion
----------

[DI] Remove an unused property

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  |no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

e5bb2bc [DI][DoctrineBridge] Remove unused underscoreMap properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
DependencyInjection Status: Needs Review
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@dunglas @ro0NL @nicolas-grekas @fabpot @xabbuh @ogizanagi @carsonbot