[Cache] fix cleanup of expired items for PdoAdapter #23326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23416fd to
6fd9516
Compare
ro0NL
reviewed
Jun 30, 2017
| * @throws InvalidArgumentException When namespace contains invalid characters | ||
| * @throws \InvalidArgumentException When first argument is not PDO nor Connection nor string | ||
| * @throws \InvalidArgumentException When PDO error mode is not PDO::ERRMODE_EXCEPTION | ||
| * @throws \InvalidArgumentException When namespace contains invalid characters |
There was a problem hiding this comment.
Ah you are right! Did not see the use Symfony\Component\Cache\Exception\InvalidArgumentException 😋
6fd9516 to
c183b0e
Compare
xabbuh
approved these changes
Jul 2, 2017
|
Thank you @dmaicher. |
fabpot
added a commit
that referenced
this pull request
Jul 3, 2017
…her) This PR was merged into the 3.2 branch. Discussion ---------- [Cache] fix cleanup of expired items for PdoAdapter | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23313 | License | MIT | Doc PR | - This fixes the query being executed to cleanup expired items from the `cache_items` table using the `PdoAdapter`. I also added a test case to make sure we do the cleanup successfully. Commits ------- c183b0e [Cache] fix cleanup of expired items for PdoAdapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the query being executed to cleanup expired items from the
cache_itemstable using thePdoAdapter.I also added a test case to make sure we do the cleanup successfully.