[Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer #23337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Aliance , I stole you this mini practice to exercise my Symfony PR ;-) (I'm a newbie) |
dunglas
requested changes
Jul 3, 2017
| @@ -497,6 +497,23 @@ public function testPrivateSetter() | |||
| $this->assertEquals('bar', $obj->getFoo()); | |||
| } | |||
|
|
|||
| public function testHasGetterDenormalize() | |||
| { | |||
| $obj = $this->normalizer->denormalize(array('foo' => true), __NAMESPACE__.'\ObjectWithHasGetterDummy'); | |||
There was a problem hiding this comment.
You can use ObjectWithHasGetterDummy::class
| public function testHasGetterDenormalize() | ||
| { | ||
| $obj = $this->normalizer->denormalize(array('foo' => true), __NAMESPACE__.'\ObjectWithHasGetterDummy'); | ||
| $this->assertEquals(true, $obj->hasFoo()); |
There was a problem hiding this comment.
$this->assertTrue($obj->hasFoo())
|
|
||
| class ObjectWithHasGetterDummy | ||
| { | ||
| private $foo = null; |
There was a problem hiding this comment.
= null is useless, it's the default value.
… Normalizer/Denormalizer
|
@dunglas , you can check :-) |
Aliance
approved these changes
Jul 5, 2017
dunglas
approved these changes
Jul 5, 2017
fabpot
approved these changes
Jul 6, 2017
|
Thank you @jordscream. |
fabpot
added a commit
that referenced
this pull request
Jul 6, 2017
… Method for the Normalizer/Denormalizer (jordscream) This PR was merged into the 3.4 branch. Discussion ---------- [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | ? | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23314 | License | MIT | Doc PR | symfony/symfony-docs Deal it with Has Method for the Normalizer/Denormalizer Commits ------- a15829d [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal it with Has Method for the Normalizer/Denormalizer