[Serializer] AbstractObjectNormalizer: Allow to disable type enforcement #23404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jul 5, 2017
| @@ -289,6 +290,10 @@ private function validateAndDenormalize($currentClass, $attribute, $data, $forma | |||
| } | |||
| } | |||
|
|
|||
| if (isset($context[self::DISABLE_TYPE_ENFORCEMENT]) && $context[self::DISABLE_TYPE_ENFORCEMENT]) { | |||
nicolas-grekas
approved these changes
Jul 12, 2017
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 12, 2017
…e type enforcement (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [Serializer] AbstractObjectNormalizer: Allow to disable type enforcement | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | no | New feature? | yes <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes (failure unrelated) | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A This allows to denormalize simple DTOs with public properties using the property-info component and the `ObjectNormalizer`. The raised exception is not really useful in such cases, as it cannot be easily handled gracefully to build a proper violation response (too generic and no real hint on the complete attribute path for instance). Instead, I use the validator component to validate my DTOs and the properties' types, get a proper violation list, and build a response from it. I wasn't really inspired for the `DISABLE_TYPE_ENFORCEMENT` name. Commits ------- 959ac2a [Serializer] AbstractObjectNormalizer: Allow to disable type enforcement
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to denormalize simple DTOs with public properties using the property-info component and the
ObjectNormalizer. The raised exception is not really useful in such cases, as it cannot be easily handled gracefully to build a proper violation response (too generic and no real hint on the complete attribute path for instance).Instead, I use the validator component to validate my DTOs and the properties' types, get a proper violation list, and build a response from it.
I wasn't really inspired for the
DISABLE_TYPE_ENFORCEMENTname.