[VarDumper] Reduce size of serialized Data objects #23413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
78076a1 to
04b8671
Compare
04b8671 to
70bd2bc
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 5, 2017
…s-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [VarDumper] Reduce size of serialized Data objects | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #23233 | License | MIT | Doc PR | - By using `Stub` objects a lot, especially for arrays, `Data` objects generate heavy serialized strings. By implemeting `Serializable` on `Data`, this PR removes most of the boilerplate. This PR also removes duplicate data in `LoggerDataCollector`, and reduces the backtrace of silenced errors to their 3 last items - which should be enough - and is otherwise responsible for a significant portion of the serialized payloads. This is not the last possible step towards shrinking serialized profiles, but the next one is more complex -and maybe this one is good enough? Please give feedback if you can. Commits ------- 70bd2bc [VarDumper] Reduce size of serialized Data objects
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jul 10, 2017
This PR was merged into the 3.2 branch. Discussion ---------- [HttpKernel] fix DumpDataCollector tests | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | to reflect the changes from #23413 Commits ------- 5dbee5b [HttpKernel] fix DumpDataCollector tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using
Stubobjects a lot, especially for arrays,Dataobjects generate heavy serialized strings.By implemeting
SerializableonData, this PR removes most of the boilerplate.This PR also removes duplicate data in
LoggerDataCollector, and reduces the backtrace of silenced errors to their 3 last items - which should be enough - and is otherwise responsible for a significant portion of the serialized payloads.This is not the last possible step towards shrinking serialized profiles, but the next one is more complex -and maybe this one is good enough? Please give feedback if you can.