Skip to content

[DI][Security] Prevent unwanted deprecation notices when using Expression Languages #23417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2017
Merged

[DI][Security] Prevent unwanted deprecation notices when using Expression Languages #23417

merged 1 commit into from
Jul 6, 2017

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jul 5, 2017 •
edited
Loading

Q A
Branch? 3.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@dunglas
Copy link
Member Author

dunglas commented Jul 5, 2017

The CacheItemPoolInterface typehint should be added when merging in master. Or I can open another PR for that if you prefer.

@dunglas dunglas changed the title [DI][Security] Prevent unwanted deprecation notices when using Expres… [DI][Security] Prevent unwanted deprecation notices when using Expression Languages Jul 5, 2017
@fabpot
Copy link
Member

fabpot commented Jul 6, 2017

Thank you @dunglas.

@fabpot fabpot merged commit 052b8c3 into symfony:3.2 Jul 6, 2017
fabpot added a commit that referenced this pull request Jul 6, 2017
@fabpot
bug #23417 [DI][Security] Prevent unwanted deprecation notices when u…
15938b4 
…sing Expression Languages (dunglas)

This PR was merged into the 3.2 branch.

Discussion
----------

[DI][Security] Prevent unwanted deprecation notices when using Expression Languages

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

052b8c3 [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
This was referenced Jul 17, 2017
Merged
Merged
@dunglas dunglas deleted the fix_expression_language_dep branch December 23, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug DependencyInjection Security Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunglas @fabpot @carsonbot