require the XML PHP extension #23421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Jul 6, 2017
fabpot
requested changes
Jul 6, 2017
| @@ -17,6 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.9", | |||
| "ext-xml": "*", | |||
There was a problem hiding this comment.
This should be removed as DI is an optional dep.
There was a problem hiding this comment.
Not sure about this. Which part of the DebugBundle would you use without the DI extension?
| @@ -17,6 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.9", | |||
| "ext-xml": "*", | |||
There was a problem hiding this comment.
I would keep it as using the bundle without DI is probably not a use case anyway.
| @@ -17,6 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.9", | |||
| "ext-xml": "*", | |||
There was a problem hiding this comment.
This should be removed as DI is an optional dep.
| @@ -17,6 +17,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.3.9", | |||
| "ext-xml": "*", | |||
There was a problem hiding this comment.
This should be removed as DI is an optional dep.
|
Why exclude TwigBundle and WebProfilerBundle? |
|
Nvm, meant to be optional apparently. |
Tobion
approved these changes
Jul 6, 2017
|
@Tobion TwigBundle and WebProfilerBundle are used by Silex without the Symfony container. |
fabpot
approved these changes
Jul 6, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 6, 2017
This PR was merged into the 2.7 branch. Discussion ---------- require the XML PHP extension | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22676 (comment), symfony/symfony-standard#1099 | License | MIT | Doc PR | I suggest to either revert #22676 or to be consistent and require the XML extension in all bundles as well as in the `symfony/symfony` package. Commits ------- 032e654 require the XML PHP extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to either revert #22676 or to be consistent and require the XML extension in all bundles as well as in the
symfony/symfonypackage.