Fixed HttpOnly flag when using Cookie::fromString() #23426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jul 6, 2017
kalimerre
approved these changes
Jul 6, 2017
|
Suggested commit message: |
The specification states that the cookie should be considered http only if and only if the flag is present. See https://www.owasp.org/index.php/HttpOnly
|
Updated commit message accordingly :) |
nicolas-grekas
approved these changes
Jul 6, 2017
nicolas-grekas
approved these changes
Jul 6, 2017
fabpot
approved these changes
Jul 6, 2017
|
Thank you @Toflar. |
fabpot
added a commit
that referenced
this pull request
Jul 6, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Fixed HttpOnly flag when using Cookie::fromString() | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23424 | License | MIT | Doc PR | - Using `Cookie::fromString()` should not set the `HttpOnly` flag to `true` by default. This is a factory method and it should create an instance of `Cookie` that represents exactly what the string contains. Commits ------- 73187d0 Preserve HttpOnly value when deserializing a header
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Cookie::fromString()should not set theHttpOnlyflag totrueby default. This is a factory method and it should create an instance ofCookiethat represents exactly what the string contains.