[DI] Remove remaining deprecated features #23484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eee1a1d to
8b33d15
Compare
stof
reviewed
Jul 12, 2017
| */ | ||
| public function process(ContainerBuilder $container) | ||
| { | ||
| $resolveClassPassChanges = null !== $this->resolveClassPass ? $this->resolveClassPass->getChanges() : array(); |
There was a problem hiding this comment.
do we still need the ResolveClassPass::getChanges() method (which requires making the compiler pass stateful) ?
There was a problem hiding this comment.
good catch, fixed
8b33d15 to
4bd7b92
Compare
Simperfit
approved these changes
Jul 12, 2017
fabpot
approved these changes
Jul 12, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 12, 2017
…kas) This PR was merged into the 4.0-dev branch. Discussion ---------- [DI] Remove remaining deprecated features | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - * removed autowiring services based on the types they implement * removed the `DefinitionDecorator` class, replaced by `ChildDefinition` * removed the `AutowireServiceResource` class and related `AutowirePass::createResourceForClass()` method * removed `LoggingFormatter`, `Compiler::getLoggingFormatter()` and `addLogMessage()` class and methods, use the `ContainerBuilder::log()` method instead * removed `FactoryReturnTypePass` * removed `ContainerBuilder::addClassResource()`, use the `addObjectResource()` or the `getReflectionClass()` method instead. * removed support for top-level anonymous services * removed silent behavior for unused attributes and elements * Removed the "framework.validation.cache" configuration option. Configure the "cache.validator" service under "framework.cache.pools" instead. Commits ------- 4bd7b92 [DI] Remove remaining deprecated features
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefinitionDecoratorclass, replaced byChildDefinitionAutowireServiceResourceclass and relatedAutowirePass::createResourceForClass()methodLoggingFormatter,Compiler::getLoggingFormatter()andaddLogMessage()class and methods, use theContainerBuilder::log()method insteadFactoryReturnTypePassContainerBuilder::addClassResource(), use theaddObjectResource()or thegetReflectionClass()method instead.