[FrameworkBundle] Set default public directory on install assets #23513
Conversation
|
This will break applications that are using the old directory structure and just update their dependencies using |
|
@xabbuh right, but this is about default value for default directory structure 4.0, still you can use the |
|
Upgrade note added. But still I'm not sure if we should add a warning messages on 3.4 on |
|
4.0 can provide the target path as well ;-) it's not like we must update on this side. It does makes sense though :) however you need to trigger a deprecation in 3.4 first (if the argument is not given) i guess. |
|
What about doing something similar to what I did in #23535? |
|
@fabpot I've rebased to |
UPGRADE-4.0.md
Outdated
| @@ -223,6 +223,8 @@ Form | |||
| FrameworkBundle | |||
| --------------- | |||
|
|
|||
| * The `assets:install` command does not install assets into `web` directory by default, but into `public` directory. | |||
There was a problem hiding this comment.
That's not true anymore. It will install under public or web.
|
Thank you @yceruto. |
…assets (yceruto) This PR was squashed before being merged into the 3.3 branch (closes #23513). Discussion ---------- [FrameworkBundle] Set default public directory on install assets | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - After symfony/flex#122 and symfony/recipes#106 the default directory to install assets is `public`. Commits ------- 1bdfe0b [FrameworkBundle] Set default public directory on install assets
After symfony/flex#122 and symfony/recipes#106 the default directory to install assets is
public.