[PropertyInfo] conflict for phpdocumentor/reflection-docblock 3.2 #23549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR related to this behaviour change is phpDocumentor/ReflectionDocBlock#89 (note the change regular expression). I guess that this should be solved in the the |
|
@xabbuh Do we need to open an issue on the upstream repo about this BC break? |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 17, 2017
…ock 3.2 (xabbuh) This PR was merged into the 3.2 branch. Discussion ---------- [PropertyInfo] conflict for phpdocumentor/reflection-docblock 3.2 | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `phpdocumentor/reflection-docblock` included a change in release 3.2.0 which required a tag to be followed by a space. This conflicts with our use of the `@Group` annotation: ```php /** * @var \DateTime[] * @groups({"a", "b"}) */ public $collection; ``` Commits ------- 58d49f7 conflict for phpdocumentor/reflection-docblock 3.2
|
I think we should: phpDocumentor/ReflectionDocBlock#108 |
|
See PR #107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpdocumentor/reflection-docblockincluded a change in release 3.2.0which required a tag to be followed by a space. This conflicts with our
use of the
@Groupannotation: