[Config] Make ClassExistenceResource throw on invalid parents #23573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9a2cde2 to
53b0190
Compare
|
I've tested this and it's better ... but it doesn't solve the issue for me yet. Original error message
Error message after this PR
Expected error message that would help me a lot
|
|
Can you check the "previous" exceptions? Basically, this may be fixed by reverting the order of displayed exceptions (or any other way to make previous exceptions more visible). But for another PR then. |
fabpot
approved these changes
Jul 19, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2017
…nts (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Config] Make ClassExistenceResource throw on invalid parents | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23564 | License | MIT | Doc PR | - Let's throw a more specific exception when a parent class/interface/trait is missing. Fine tunes #23041 Commits ------- 53b0190 [Config] Make ClassExistenceResource throw on invalid parents
Merged
ogizanagi
added a commit
that referenced
this pull request
Jul 19, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [Config] Minor fix | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - My bad. BTW @javiereguiluz I confirm my diagnosis on #23573 Here is the last exception in that error page:  Commits ------- fa0b942 [Config] Minor fix
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's throw a more specific exception when a parent class/interface/trait is missing.
Fine tunes #23041