[Cache] Handle serialization failures for Memcached #23615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12bd3c2 to
df3cc55
Compare
|
So, what would be your stand on #19895? |
|
Accidentally hit delete when editing my original message; here it is again:
I think my initial reaction was an uneducated gut-reaction without fully understanding the intentions of this PR; if your goal is #19895 (comment), then I'm onboard, and may even have some time to contribute towards those goals. |
|
My goal with this PR is to have a predictable, thus safe, default behavior. :) |
fabpot
approved these changes
Jul 22, 2017
df3cc55 to
ddab824
Compare
|
Rebased to target 3.3 |
ddab824 to
b14b0e1
Compare
b14b0e1 to
cccc88f
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 26, 2017
…as-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [Cache] Handle serialization failures for Memcached | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes two issues with serialization + memcached: with the memcached extension, the default serializer is automatically selected as igbinary when possible, native php otherwise. That creates obvious migration/portability issues (ie just installing igbinary wipes out the value of your cache.) Then, handling unserializing failures (esp. "php_incomplete_class") is a paramount feature of the component. You must be able to deal with migrating you code base without being blocked by some legacy serialized data. Commits ------- cccc88f [Cache] Handle unserialization failures for Memcached
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with serialization + memcached: with the memcached extension, the default serializer is automatically selected as igbinary when possible, native php otherwise. That creates obvious migration/portability issues (ie just installing igbinary wipes out the value of your cache.)
Then, handling unserializing failures (esp. "php_incomplete_class") is a paramount feature of the component. You must be able to deal with migrating you code base without being blocked by some legacy serialized data.