Skip to content

[PropertyInfo] Add hassers for accessors prefixes #23617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

sebdec
Copy link
Contributor

@sebdec sebdec commented Jul 21, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets None
License MIT
Doc PR -

In the component PropertyInfo
In the class ReflectionExtractor Add hassers in the accessors prefixes

Because I think it's common to have readable properties with method like this:
hasChildren()

@javiereguiluz javiereguiluz changed the title Add assers for accessors prefixes Add hassers for accessors prefixes Jul 21, 2017
@sebdec
Copy link
Contributor Author

sebdec commented Jul 21, 2017

maybe it can be defined as a bug fix

@nicolas-grekas nicolas-grekas changed the title Add hassers for accessors prefixes [PropertyInfo] Add hassers for accessors prefixes Jul 25, 2017
@nicolas-grekas nicolas-grekas requested a review from dunglas July 25, 2017 12:46
@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Jul 25, 2017
@jakzal
Copy link
Contributor

jakzal commented Oct 25, 2017

Would be nice to have it. It's a new feature though.

@xabbuh xabbuh modified the milestones: 3.3, 4.1 Nov 15, 2017
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for master

@fabpot
Copy link
Member

fabpot commented Feb 7, 2018

Thank you @sebdec.

@fabpot fabpot closed this Feb 7, 2018
fabpot added a commit that referenced this pull request Feb 7, 2018
…dec)

This PR was submitted for the 3.3 branch but it was squashed and merged into the 4.1-dev branch instead (closes #23617).

Discussion
----------

[PropertyInfo] Add hassers for accessors prefixes

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | None
| License       | MIT
| Doc PR        | -

In the component PropertyInfo
In the class ReflectionExtractor Add hassers in the accessors prefixes

Because I think it's common to have readable properties with method like this:
hasChildren()

Commits
-------

03bce5e [PropertyInfo] Add hassers for accessors prefixes
@fabpot fabpot mentioned this pull request May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants