[FrameworkBundle] Commands as a service #23624

ro0NL · 2017-07-22T10:36:18Z

Q	A
Branch?	3.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	yes
Tests pass?	yes/no
Fixed tickets	#...
License	MIT
Doc PR	symfony/symfony-docs#...

Next step towards #23488

It's a work in progress if we want to do all commands at once (im fine :)). But i think we should review assets:install first.

Also im assuming framework commands can rely on getApplication()->getKernel() from the framework application (we already do that in some commands). That saves a dep on @kernel.

And filesystem as a service; perhaps drop that as well :)

linaori · 2017-07-22T10:50:26Z

And filesystem as a service; perhaps drop that as well :)

@ro0NL while should be another RFC, this is probably not a good thing to do for mocking reasons

chalasr · 2017-07-22T11:04:58Z

all commands at once

let's do that :)

ro0NL · 2017-07-22T11:21:05Z

Alright. Next is cache:pool:clear.. this one requires all pools by id from the container.

It may benefit from #22200 so it gets cache.pool tagged services. But we need them as a map, indexed by service id 😅 which we can provide as default implem. for !tagged-services.

/cc @nicolas-grekas

edit: that would be the global clearer, which it already has. Basically this command allows for any cleaer-ish like service, so truly needs to be container aware. Bummer :)

or inject @service_container

nicolas-grekas · 2017-07-22T13:07:05Z

@ro0NL support for by-id maps in tagged-services wouldn't help us remove the CachePoolClearerPass, which has additional logic that can't be replaced solely by the tag. So, remark is off topic :)

ro0NL · 2017-07-22T13:52:45Z

Right! I'd already move forward with injecting @service_container, some other need that as well. Imo. thats good enough to bridge to whatever it's refactored to, some day.

Ready for review.

Btw @iltar need any help with symfony/acl-bundle#2? Regarding the commands we need to decide what to do.

nicolas-grekas · 2017-07-22T14:04:13Z

tests still need some love ;)

chalasr

thanks for working on this

chalasr · 2017-07-22T13:22:32Z

src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php

+    {
+        parent::__construct();
+
+        if (!$filesystem instanceof Filesystem) {


I suggest making $filesystem optional (last, nullable, creating it if not passed)

For assets:installs that makes $baseDir the 1st argument, which is as $name also string. Ie we cant detect if user passes name (old api) or path (new api).

I like $filesystem being last and optional though. Suggestions?

We can make $filesystem optional as of 4.0 perhaps =/

What about using is_dir($baseDir) to differentiate a command name from the base dir, if we make it the first constructor arg?
The baseDir is already supposed to exist. The command will throw an exception otherwise.

I was going for that, but you still get different behavior :) before: exception, after: a path-ish command name.

A way could be to get the path from getApplication()->getKernel()->getContainer()->getParameter() =/

Lets make everything optional then 🤣 should work out.

chalasr · 2017-07-22T14:41:49Z

src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php

+        @trigger_error(sprintf('Method "%s" is deprecated since version 3.4 and "%s" won\'t extend "%s" nor implement "%s" anymore in 4.0.', __METHOD__, __CLASS__, ContainerAwareCommand::class, ContainerAwareInterface::class), E_USER_DEPRECATED);
+
+        return parent::getContainer();
+    }


not needed as the class is final

chalasr · 2017-07-22T14:45:04Z

src/Symfony/Bundle/FrameworkBundle/Command/CacheWarmupCommand.php

+
+    /**
+     * {@inheritdoc}
+     */


missing @deprecated (same for all others)

chalasr · 2017-07-22T14:46:45Z

src/Symfony/Bundle/FrameworkBundle/Resources/config/console.xml

@@ -12,5 +12,63 @@
            <tag name="kernel.event_subscriber" />
            <tag name="monolog.logger" channel="console" />
        </service>
+
+        <service id="command.about" class="Symfony\Bundle\FrameworkBundle\Command\AboutCommand">


should we prefix them all by console?

dunno.. it seems to be <extension>.command.name, except for framework :) there's no framework. prefix. Hence namespaced under root.

I'm 👍 for adding the console prefix.

(I have no opinion really :))

Security bundle introduced security.console.user_password_encoder_command while webserver bundle did web_server.command.server_run; i took the latter as template.

So im in the middle here :) however i always thought console and command are sibling namespaces. Where console namespace is used for library stuff (console.command_loader, console.error_listener), and command for commands solely.

For the record and what it's worth, the pass use console.command tag & prefix.

web_server.command.server_run looks ok to me, as we already have a root prefix. So there is few chances to be used in userland.
security.console.user_password_encoder_command was not conform to this last convention, but the web server bundle didn't exist yet nor any convention for command as service at the time it was introduced. So I used mine, i.e: (namespace|context).component.snaked_case_class_name :)

Finally, command as root prefix might mean something else in userland. It can be one of your domain bounded context you use as prefix for related services, or simply the prefix you chose for your command handlers when using command buses.

Actually, I don't really mind either; there are few chances there is any conflict with any existing app. Just saying it won't hurt having this prefix :)

Updated 👍

May be worth it to update security.console.user_password_encoder_command to security.command.user_password_encoder

chalasr · 2017-07-22T14:51:16Z

src/Symfony/Bundle/FrameworkBundle/Resources/config/console.xml

+        </service>
+
+        <service id="command.router_debug" class="Symfony\Bundle\FrameworkBundle\Command\RouterDebugCommand">
+            <argument type="service" id="router" />


should be null if invalid as the command was calling has() (same below)

RouterDebugCommand doesnt accept null ;) i remove the definition if routing is disabled in the framework extension.

ogizanagi · 2017-07-22T17:20:01Z

src/Symfony/Bundle/FrameworkBundle/Command/EventDispatcherDebugCommand.php

@@ -87,6 +130,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
     */
    protected function getEventDispatcher()


@deprecated since 3.4 and will be removed in 4.0.

ogizanagi · 2017-07-22T17:21:30Z

src/Symfony/Bundle/FrameworkBundle/Command/EventDispatcherDebugCommand.php

+        if (__CLASS__ !== get_class($this)) {
+            $r = new \ReflectionMethod($this, 'getEventDispatcher');
+            if (__CLASS__ !== $r->getDeclaringClass()->getName()) {
+                @trigger_error(sprintf('Usage of method "%s" is deprecated since version 3.4 and will no longer be supported in 4.0.', get_class($this).'::getEventDispatcher'), E_USER_DEPRECATED);


- 'Usage of method "%s" is deprecated since version 3.4 and will no longer be supported in 4.0.' + 'Usage of method "%s" is deprecated since version 3.4 and will no longer be supported in 4.0. Inject an event dispatcher instance using the constructor instead.'

?

Appended with Construct the command with its required arguments instead. Also applied to getTwigEnvironment usage in twig bundle.

This PR was merged into the 3.2 branch. Discussion ---------- Remove unused mocks/vars | Q | A | ------------- | --- | Branch? | 3.2 Spotted in #23624 Commits ------- 445c56a Remove unused mocks/vars

@deprecated

This PR was merged into the 3.3 branch. Discussion ---------- Remove unused prop + added @deprecated | Q | A | ------------- | --- | Branch? | 3.3 Spotted in #23624 Commits ------- 07ff4dd Remove unused prop + added @deprecated

ogizanagi · 2017-07-23T10:34:53Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

     */
-    private $filesystem;
+    public function __construct($baseDir = null, Filesystem $filesystem = null /**, $newApi = false*/)


About $newApi: I think we already had such flags in the past, but we never introduced them commented.
Instead (if this trick is accepted by other reviewers), I'd suggest to uncomment and document this option in the docBlock, mentioning it'll only be necessary until 4.0, version in which it'll finally get removed.

I would remove it, make $filesystem the first arg and check for its type instead ($basedir being the only one with no typehint)

oops, we made $filesystem optional... then I would just remove the commented arg and don't document it at all

IMHO it should be clear for anyone willing to switch to the new API that this flag must be set to true until 4.0, time at which it'll be safely removed. So the argument must exist, and should be documented.

right. then we would have to deprecate it and remove it... should we forgot about the optional filesystem instead?

Are you sure? From what I see, it must always be a dir.

See #23624 (comment)

Not having an exception until 4.0 would be fine for me but I understand your point :)

@GuilhemN Application::getKernel() returns KernelInterface which does not provide getProjectDir(). I'd keep injecting it just to avoid a call to getContainer()->getParameter(...).

Ok, that's a good point :)

GuilhemN · 2017-07-28T19:40:51Z

src/Symfony/Bundle/FrameworkBundle/Command/CacheClearCommand.php

+        }
+
+        $this->cacheClearer = $cacheClearer;
+        $this->cacheDir = $cacheDir;


Same, imo calling Kernel::getCacheDir() is enough.

GuilhemN · 2017-07-28T19:41:59Z

src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php

+        }
+
+        $this->poolClearer = $poolClearer;
+        $this->cacheDir = $cacheDir;


GuilhemN · 2017-07-28T19:45:57Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

     */
-    private $filesystem;
+    public function __construct($baseDir = null, Filesystem $filesystem = null /**, $newApi = false*/)


Are you sure? From what I see, it must always be a dir.

GuilhemN · 2017-07-28T19:47:46Z

src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php

                $pools[$id] = $id;
            } else {
-                $pool = $container->get($id);
+                $pool = $kernel->getContainer()->get($id);


parent::getContainer()?

it won't be containeraware in 4.0, but this will still be supported

Ok, it was just to be consistent with the code above but that's fine for me.

We basically favor kernel aware over container aware. See also #23632

We might favor kernel injection over kernel aware. That would be the most flexible, but not sure if needed.

GuilhemN · 2017-07-28T19:51:14Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

     */
-    private $filesystem;
+    public function __construct($baseDir = null, Filesystem $filesystem = null /**, $newApi = false*/)


Not having an exception until 4.0 would be fine for me but I understand your point :)

GuilhemN · 2017-07-28T19:54:11Z

src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php

@@ -25,6 +25,29 @@
 */
 final class CachePoolClearCommand extends ContainerAwareCommand


The getContainer() is missing here, right?

getContainer() is protected so the deprecation would be triggered only if called from a subclass, but this is final :)

Indeed... I should have reviewed more carefully 😊

GuilhemN · 2017-07-28T19:55:39Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

     */
-    private $filesystem;
+    public function __construct($baseDir = null, Filesystem $filesystem = null /**, $newApi = false*/)


Ok, that's a good point :)

GuilhemN · 2017-07-28T19:58:10Z

src/Symfony/Bundle/FrameworkBundle/Command/CacheWarmupCommand.php

        }

-        $warmer->warmUp($this->getContainer()->getParameter('kernel.cache_dir'));
+        $this->cacheWarmer->warmUp(null === $this->cacheDir ? $kernel->getCacheDir() : $this->cacheDir);


This case is already supported above, isn't it?

Nope. Above is for BC, as long as the command extends ContainerAwareCommand we need to get the cachedir from the container, if not provided already.

This is the new behavior if cachedir is not provided in 4.0.

However i still have my concerns about getCacheDir() vs getParameter('cachedir'). I think we should actually prefer getParameter(), also in 4.0.

chalasr · 2017-07-28T20:14:58Z

src/Symfony/Bundle/FrameworkBundle/Command/CachePoolClearCommand.php

+            $this->poolClearer = $this->getContainer()->get('cache.global_clearer');
+        }
+        if (null === $this->cacheDir) {
+            $this->cacheDir = parent::getContainer()->getParameter('kernel.cache_dir');


should use $this instead of parent

ro0NL · 2017-07-29T08:16:11Z

Im having my thoughts about cache_dir/project_dir as an optional constructor arg. Do we really, really need it? It's not like the framework commands should be very abstract and generic, and we fallback to the parameter anyway.

My vote goes to simply getKernel()->getContainer()->getParameter(). Which works for project_dir and cache_dir (im favoring getParameter() over getCacheDir() as well).

That would fix the argument hassle in assets:install :) while remaining consistency with other commands.

chalasr · 2017-07-31T22:00:00Z

No objection for getKernel()->getContainer()->getParameter('kernel.*') on my side.

ro0NL · 2017-08-01T09:29:29Z

Done.

Last thing; i noticed cache:pool:prune is added in between and is registered in cache.xml, the definition is, AFAIK, not removed if Console\Application is unavailable. I tend to register all commands in console.xml which is only loaded under that condition, and then additionally remove specific command definitions if its component is unavailable. This also applies to #23694

Is that the right approach, or should we inverse it? And does it need a class_exists(Application::class) check?

ro0NL · 2017-08-05T12:50:51Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

+    {
+        parent::__construct();
+
+        if (!$filesystem instanceof Filesystem) {


Argh... null implies new api?

null has never been an allowed name so LGTM as is

actually it is.. https://github.com/symfony/symfony/blob/v3.3.6/src/Symfony/Component/Console/Command/Command.php#L51

leaning to make filesystem a required dep..

fine for me

ro0NL · 2017-08-05T12:54:40Z

src/Symfony/Bundle/TwigBundle/Resources/config/console.xml

            <argument type="service" id="twig" />
            <tag name="console.command" command="lint:twig" />
        </service>
-
-        <!-- BC to be removed in 4.0 -->


removed this bc layer in favor of making TwigBundle::registerCommands a noop

nicolas-grekas · 2017-08-05T13:29:42Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

+            return;
+        }
+
+        $this->filesystem = $filesystem ?: new Filesystem();


the ?: ... is useless, isn't it?

kinda yes.. in 4.0 it would be ?? ... and in 3.4 the else may not happen (depends on discussion above :))

yceruto · 2017-08-05T15:35:31Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

@@ -695,6 +695,13 @@ private function registerDebugConfiguration(array $config, ContainerBuilder $con
     */
    private function registerRouterConfiguration(array $config, ContainerBuilder $container, XmlFileLoader $loader)
    {
+        if (!$this->isConfigEnabled($container, $config)) {
+            $container->removeDefinition('console.command.router_debug');
+            $container->removeDefinition('console.command.router_match');


https://travis-ci.org/symfony/symfony/jobs/261303308#L2572 should be updated to FQCN?

nicolas-grekas · 2017-08-06T10:29:21Z

Thank you @ro0NL.

chalasr · 2017-08-06T10:33:56Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

+        parent::__construct();
+
+        if (!$filesystem instanceof Filesystem) {
+            @trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version 3.4 and will be removed in 4.0. If the command was registered by convention, make it a service instead.', __METHOD__), E_USER_DEPRECATED);


message is confusing if I was not passing anything as argument

chalasr · 2017-08-06T10:37:46Z

src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php

+        if (!$filesystem instanceof Filesystem) {
+            @trigger_error(sprintf('Passing a command name as the first argument of "%s" is deprecated since version 3.4 and will be removed in 4.0. If the command was registered by convention, make it a service instead.', __METHOD__), E_USER_DEPRECATED);
+
+            $this->setName(null === $filesystem ? 'assets:install' : $filesystem);


parent::__construct($filesystem);? calling setName() now is a behavior change, it's called in configure anyway.

Hm you're right.. configure() always wins.. ill have a look at it.

nicolas-grekas · 2017-08-06T10:42:30Z

@ro0NL merged up to master, PR welcomed for the 4.0 cleanup :)

@chalasr

This PR was squashed before being merged into the 3.4 branch (closes #23801). Discussion ---------- Continuation of #23624 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  See #23624 (comment) cc @chalasr Also included service injection for init:acl + set:acl and simplification of lint:xliff + lintt:yaml. Btw, i think init:acl needs to be renamed to acl:init :) Commits ------- 5f637c1 Continuation of #23624

@chalasr

This PR was squashed before being merged into the 3.4 branch (closes #23801). Discussion ---------- Continuation of #23624 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #...  | License | MIT | Doc PR | symfony/symfony-docs#...  See symfony/symfony#23624 (comment) cc @chalasr Also included service injection for init:acl + set:acl and simplification of lint:xliff + lintt:yaml. Btw, i think init:acl needs to be renamed to acl:init :) Commits ------- 5f637c1 Continuation of #23624

* 3.4: Continuation of #23624

…ervices (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- Fix deprecations regarding core commands registered as services | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23624 (comment) | License | MIT | Doc PR | n/a Current deprecation messages can be confusing (see fixed ticket), this improves them and adds a bunch of missing CHANGELOG/UPGRADE entries on the same topic Commits ------- 4659975 Fix deprecations regarding core commands registered as services

…ommand service id (kbond) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] fix CachePoolPrunerPass to use correct command service id | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23451 (comment) | License | MIT | Doc PR | n/a #23624 broke #23451. Commits ------- 14c62da fix CachePoolPrunerPass to use correct command service id

carsonbot added Status: Needs Review FrameworkBundle Feature Deprecation labels Jul 22, 2017

chalasr requested changes Jul 22, 2017

View reviewed changes

ogizanagi reviewed Jul 22, 2017

View reviewed changes

This was referenced Jul 22, 2017

Remove unused mocks/vars #23627

Merged

Remove unused prop + added @deprecated #23628

Merged

ogizanagi reviewed Jul 23, 2017

View reviewed changes

nicolas-grekas added this to the 3.4 milestone Jul 25, 2017

ro0NL mentioned this pull request Jul 26, 2017

[FrameworkBundle] Add a framework aware base command #23632

Closed

GuilhemN reviewed Jul 28, 2017

View reviewed changes

chalasr reviewed Jul 28, 2017

View reviewed changes

ro0NL mentioned this pull request Jul 31, 2017

[Form] Add debug:form command #23694

Merged

ro0NL added 2 commits August 1, 2017 11:19

[FrameworkBundle] Commands as a service

da49f81

favor getKernel()->getContainer()->getParameter()

48228aa

move cache:pool:prune to console.xml

76097b3

class named services

9b0a5a4

ro0NL commented Aug 5, 2017

View reviewed changes

nicolas-grekas reviewed Aug 5, 2017

View reviewed changes

yceruto reviewed Aug 5, 2017

View reviewed changes

ro0NL added 4 commits August 6, 2017 11:23

marked commands final

d99e0b9

filesystem required dep in assets:install

a404323

removed bc layers in favor of final

d0b35d0

patched security bundle

2067d8a

chalasr reviewed Aug 6, 2017

View reviewed changes

nicolas-grekas closed this in 736f0d0 Aug 6, 2017

nicolas-grekas mentioned this pull request Aug 6, 2017

Deprecate auto-discovery of commands in their directories #23488

Closed

ro0NL deleted the framework/commands branch August 6, 2017 10:44

ro0NL mentioned this pull request Aug 6, 2017

Continuation of #23624 #23801

Closed

nicolas-grekas pushed a commit that referenced this pull request Aug 6, 2017

Continuation of #23624

5f637c1

nicolas-grekas added a commit that referenced this pull request Aug 6, 2017

Merge branch '3.4'

57e31c2

* 3.4: Continuation of #23624

This was referenced Aug 8, 2017

Initial extract from SecurityBundle symfony/acl-bundle#2

Merged

[FrameworkBundle][SecurityBundle][TwigBundle][Yaml] remove deprecated code #23815

Merged

chalasr mentioned this pull request Sep 3, 2017

Fix deprecations regarding core commands registered as services #24074

Merged

ro0NL mentioned this pull request Sep 10, 2017

[FrameworkBundle] Expose dotenv in bin/console about #24144

Merged

This was referenced Oct 18, 2017

Release v3.4.0-BETA1 #24609

Merged

Release v4.0.0-BETA1 #24612

Merged

kbond mentioned this pull request Oct 27, 2017

[FrameworkBundle] fix CachePoolPrunerPass to use correct command service id #24713

Merged

		@@ -87,6 +130,8 @@ protected function execute(InputInterface $input, OutputInterface $output)
		*/
		protected function getEventDispatcher()

		@@ -25,6 +25,29 @@
		*/
		final class CachePoolClearCommand extends ContainerAwareCommand

[FrameworkBundle] Commands as a service #23624

[FrameworkBundle] Commands as a service #23624

Conversation

ro0NL commented Jul 22, 2017

linaori commented Jul 22, 2017

chalasr commented Jul 22, 2017

ro0NL commented Jul 22, 2017 • edited Loading

nicolas-grekas commented Jul 22, 2017

ro0NL commented Jul 22, 2017

nicolas-grekas commented Jul 22, 2017

chalasr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL Jul 22, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ogizanagi Jul 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuilhemN Jul 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GuilhemN Jul 28, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL Jul 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL commented Jul 29, 2017 • edited Loading

chalasr commented Jul 31, 2017

ro0NL commented Aug 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL Aug 6, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolas-grekas commented Aug 6, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ro0NL commented Jul 22, 2017 •

edited

Loading

ro0NL Jul 22, 2017 •

edited

Loading

ogizanagi Jul 23, 2017 •

edited

Loading

GuilhemN Jul 28, 2017 •

edited

Loading

GuilhemN Jul 28, 2017 •

edited

Loading

ro0NL Jul 29, 2017 •

edited

Loading

ro0NL commented Jul 29, 2017 •

edited

Loading

ro0NL Aug 6, 2017 •

edited

Loading