[DI] Fix resetting private services #23645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Jul 24, 2017
ogizanagi
approved these changes
Jul 24, 2017
chalasr
approved these changes
Jul 24, 2017
1c0ccaa to
652494f
Compare
nicolas-grekas
commented
Jul 24, 2017
| @@ -69,7 +70,7 @@ public function getProxyFactoryCode(Definition $definition, $id, $methodName = n | |||
| $instantiation = 'return'; | |||
|
|
|||
| if ($definition->isShared()) { | |||
| $instantiation .= " \$this->services['$id'] ="; | |||
| $instantiation .= sprintf(' $this->%s[\'%s\'] =', $definition->isPublic() || !method_exists(ContainerBuilder::class, 'addClassResource') ? 'services' : 'privates', $id); | |||
There was a problem hiding this comment.
we also missed updating ProxyDumper, now fixed
ogizanagi
added a commit
that referenced
this pull request
Jul 25, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [DI] Fix resetting private services | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As spotted by @stof. Commits ------- 320cf40 [DI] Fix resetting private services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @stof.