Bump minimal PHP version to ^5.5.9|>=7.0.8 #23703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will just confuse users with <7.0.8 about why they're not getting important security updates anymore. |
|
@curry684 truth is, serializing is broken with PHP <7.0.8, so everybody should reject these versions. It's only losely related to the linked issue. |
fabpot
approved these changes
Jul 28, 2017
Simperfit
approved these changes
Jul 28, 2017
chalasr
approved these changes
Jul 28, 2017
|
I completely agree with the solution and change, just not some of its possible side effects. If 3.3.6 contains a warning for PHP <7.0.8, and we then remove that in 3.3.7 and 3.4.0 along with the Composer bump the issue is fixed, and users that are upgrading Symfony but not PHP have a clear end-of-road warning. |
ogizanagi
approved these changes
Jul 28, 2017
|
Cheers, well solved. |
nicolas-grekas
commented
Jul 29, 2017
| @@ -85,9 +85,6 @@ public function __construct(FormDataExtractorInterface $dataExtractor) | |||
| */ | |||
| public function collect(Request $request, Response $response, \Exception $exception = null) | |||
| { | |||
| if (70000 <= \PHP_VERSION_ID && \PHP_VERSION_ID < 70800) { | |||
| @trigger_error('A bug in PHP 7.0.0 to 7.0.7 is breaking the Form panel, please upgrade to 7.0.8 or higher.', E_USER_DEPRECATED); | |||
javiereguiluz
approved these changes
Jul 30, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Bump minimal PHP version to ^5.5.9|>=7.0.8 | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22973 | License | MIT | Doc PR | - As spotted in the linked issue, because of https://bugs.php.net/72229. Commits ------- 2282a6f Bump minimal PHP version to ^5.5.9|>=7.0.8
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted in the linked issue, because of https://bugs.php.net/72229.