[Webprofiler] Improve sql explain table display #23706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please rebase @mimol91 ? |
|
@mimol91 what happens when using Postgresql ? Explain output uses a |
stof
reviewed
Jul 29, 2017
| @@ -874,6 +874,13 @@ table.logs .metadata { | |||
| margin: .5em 0; | |||
| padding: 1em; | |||
| } | |||
| .sql-explain { | |||
| overflow-x: auto; | |||
| width: 920px; | |||
There was a problem hiding this comment.
should be max-width in case people have smaller screens
|
Its working as before Can i re-trigger tests? |
javiereguiluz
approved these changes
Jul 30, 2017
There was a problem hiding this comment.
@mimol91 fantastic! Thanks for contributing this improvement. I like it a lot.
|
I've rebased with 3.4 |
fabpot
approved these changes
Aug 1, 2017
|
Thank you @mimol91. |
fabpot
added a commit
that referenced
this pull request
Aug 1, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Webprofiler] Improve sql explain table display | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes? | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Table which is shown in Weprofiler is not clean while values in sql explain table are long. This PR adds horizontal scroll for long tables. **Related PR in Doctrine bundle:** doctrine/DoctrineBundle#681 _(It does not cause any backward compatibility problems)_ **Before:**  **After:**  Commits ------- 2769550 improve sql explain table display
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table which is shown in Weprofiler is not clean while values in sql explain table are long.
This PR adds horizontal scroll for long tables.
Related PR in Doctrine bundle: doctrine/DoctrineBundle#681
(It does not cause any backward compatibility problems)
Before:
After:
