[DependencyInjection] Deprecate autowiring service auto-registration #23712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas the cs issue reported by fabbot.io was done on purpose, right? |
|
Right |
fabpot
requested changes
Aug 1, 2017
UPGRADE-3.4.md
Outdated
| @@ -4,6 +4,10 @@ UPGRADE FROM 3.3 to 3.4 | |||
| DependencyInjection | |||
| ------------------- | |||
|
|
|||
| * Autowiring service auto-registration is deprecated and won't be supported | |||
| in Symfony 4.0. Explicitely inject your dependencies or create services | |||
| whose ids are their fully-qualified class name. | |||
There was a problem hiding this comment.
An example with before/after would probably help people understand what that means. For anybody not familiar with the container, this is cryptic :)
There was a problem hiding this comment.
Indeed but that's a deprecation that is hard to illustrate. I added an example that I tried to make as familiar as possible :)
ogizanagi
approved these changes
Aug 1, 2017
xabbuh
requested changes
Aug 1, 2017
UPGRADE-3.4.md
Outdated
| @@ -4,6 +4,50 @@ UPGRADE FROM 3.3 to 3.4 | |||
| DependencyInjection | |||
| ------------------- | |||
|
|
|||
| * Autowiring service auto-registration is deprecated and won't be supported | |||
| in Symfony 4.0. Explicitely inject your dependencies or create services | |||
UPGRADE-4.0.md
Outdated
| @@ -77,6 +77,50 @@ Debug | |||
| DependencyInjection | |||
| ------------------- | |||
|
|
|||
| * Autowiring service auto-registration is not supported anymore. | |||
| Explicitely inject your dependencies or create services whose ids are | |||
|
@xabbuh done |
chalasr
approved these changes
Aug 1, 2017
|
Thank you @GuilhemN. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2017
…o-registration (GuilhemN) This PR was squashed before being merged into the 3.4 branch (closes #23712). Discussion ---------- [DependencyInjection] Deprecate autowiring service auto-registration | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23350 | License | MIT | Doc PR | Fix #23350, to make autowiring more predictable. Commits ------- 969a207 [DependencyInjection] Deprecate autowiring service auto-registration
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23350, to make autowiring more predictable.