[Bridge\ProxyManager] Dont call __destruct() on non-instantiated services #23729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c366fc7 to
6fb67d5
Compare
stloyd
reviewed
Jul 31, 2017
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| protected function getGenerator() : ProxyGeneratorInterface |
There was a problem hiding this comment.
You can't use feature from PHP 7 on branch that supports version 5.5
6baa81f to
b98fc0a
Compare
stof
reviewed
Aug 1, 2017
| */ | ||
| class LazyLoadingValueHolderFactoryV1 extends BaseFactory | ||
| { | ||
| private $generatorV1; |
There was a problem hiding this comment.
why does it have a different name here ? Except for the property name, the code is the same in v1 and V2.
There was a problem hiding this comment.
Because in v0.4, the property exists and is protected, thus can't be made private...
There was a problem hiding this comment.
we could just use a name available in both versions
b98fc0a to
2d79ffa
Compare
fabpot
approved these changes
Aug 3, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Aug 3, 2017
…tiated services (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Bridge\ProxyManager] Dont call __destruct() on non-instantiated services | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - While working on making #23678 green, I discovered that if a lazy service implements `__destruct`, then that service is not lazy anymore: it is created at destruct time. That behavior is documented at Ocramius/ProxyManager#258 (+related issues). While I may understand why this behavior is the default for ProxyManager, it does not fit our "lazy-services" use case to me. Typically, nobody wants a database connection to be created to destruct the uninitialized lazy-proxy. Blocks #23678 Commits ------- 2d79ffa [Bridge\ProxyManager] Dont call __destruct() on non-instantiated services
This was referenced Aug 28, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on making #23678 green, I discovered that if a lazy service implements
__destruct, then that service is not lazy anymore: it is created at destruct time.That behavior is documented at Ocramius/ProxyManager#258 (+related issues).
While I may understand why this behavior is the default for ProxyManager, it does not fit our "lazy-services" use case to me. Typically, nobody wants a database connection to be created to destruct the uninitialized lazy-proxy.
Blocks #23678