[Config] Fix checking class existence freshness #23755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Aug 2, 2017
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23753 |
| License | MIT |
| Doc PR | - |
042a293 to
6630549
Compare
chalasr
approved these changes
Aug 2, 2017
|
The fix works for me. |
fabpot
approved these changes
Aug 2, 2017
ogizanagi
approved these changes
Aug 2, 2017
Simperfit
approved these changes
Aug 2, 2017
keichinger
reviewed
Aug 2, 2017
| @@ -74,6 +75,22 @@ public function testExistsKo() | |||
| } | |||
| } | |||
|
|
|||
| public function testBarParentWithTimestamp() | |||
There was a problem hiding this comment.
Shouldn't Bar be Bad in regards to the class name itself, BadParent?
Same goes for line 88.
6630549 to
a63ab77
Compare
javiereguiluz
approved these changes
Aug 2, 2017
|
Thank you @nicolas-grekas. |
ogizanagi
added a commit
that referenced
this pull request
Aug 2, 2017
…rekas) This PR was merged into the 3.3 branch. Discussion ---------- [Config] Fix checking class existence freshness | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23753 | License | MIT | Doc PR | - Commits ------- a63ab77 [Config] Fix checking class existence freshness
|
@nicolas-grekas @fabpot Can we tag a new release with this fix ? it seems important to me. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.