Avoid infinite loops when profiler data is malformed #23783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @javiereguiluz. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 5, 2017
…ereguiluz) This PR was merged into the 2.7 branch. Discussion ---------- Avoid infinite loops when profiler data is malformed | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22963 | License | MIT | Doc PR | - Thanks to the bug reproducer provided by @Kyoushu, I could reproduce this error: ``` PHP 7.1.4 Development Server started at Thu Aug 3 22:13:26 2017 Listening on http://127.0.0.1:8000 Document root is projects/symfony-fileprofilerstorage-bug/web Press Ctrl-C to quit. [Thu Aug 3 22:13:26 2017] PHP Fatal error: Allowed memory size of 2147483648 bytes exhausted (tried to allocate 282624 bytes) in projects/symfony-fileprofilerstorage-bug/vendor/symfony/symfony/src/Symfony/Component/ HttpKernel/Profiler/FileProfilerStorage.php on line 124 ``` After the changes proposed in this PR, the browser no longer exhausts the memory and you can see the exception page explaining the error. The web debug toolbar doesn't load, but it doesn't crash anything:  Commits ------- e5ef9fb Avoid infinite loops when profiler data is malformed
This was referenced Aug 28, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the bug reproducer provided by @Kyoushu, I could reproduce this error:
After the changes proposed in this PR, the browser no longer exhausts the memory and you can see the exception page explaining the error. The web debug toolbar doesn't load, but it doesn't crash anything: