Don't force lowercase for hasher values #23797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To make tests pass for deps=low/high lines, they should compare lowercased values. |
Simperfit
approved these changes
Aug 6, 2017
|
@Simperfit look at tests before approving ;) |
|
@nicolas-grekas I know that @javiereguiluz will take care of test anyway ^^
Le dim. 6 août 2017 à 12:28, Nicolas Grekas <notifications@github.com> a
écrit :
… @Simperfit <https://github.com/simperfit> look at tests before approving
;)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23797 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADSq8qA1_Zt8uUP4j4Pl1hnd-XkmxZvUks5sVZVVgaJpZM4Ouhm->
.
|
|
@javiereguiluz you need to patch 3.4 so that the test is case insensitive. Then there will be no need to patch tests here, only remove the strtolower call. |
chalasr
pushed a commit
that referenced
this pull request
Aug 14, 2017
…re for future Symfony versions (javiereguiluz) This PR was squashed before being merged into the 3.4 branch (closes #23852). Discussion ---------- Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is what @nicolas-grekas [told me to do](#23797 (comment)) to unlock #23797. Commits ------- 9b7750a Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions
|
ready for a rebase |
f2f3135 to
156cb70
Compare
|
Thank you @javiereguiluz. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 22, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- Don't force lowercase for hasher values | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - In Symfony 4.x we no longer modify the service ids to lowercase them, so this PR tweaks the hasher introduced in #23766. Commits ------- 156cb70 [DI] Don't force lowercase for hasher values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 4.x we no longer modify the service ids to lowercase them, so this PR tweaks the hasher introduced in #23766.