[Debug] Trigger a deprecation when using an internal class/trait/interface #23807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fabbot failure unrelated. |
| @@ -166,10 +167,14 @@ public function loadClass($class) | |||
| } | |||
|
|
|||
| $parent = get_parent_class($class); | |||
| $doc = $refl->getDocComment(); | |||
| if (preg_match('#\n \* @internal(?: .+?)?\r?\n \*(?: @|/$)#s', $doc, $notice)) { | |||
| self::$internal[$name] = true; | |||
There was a problem hiding this comment.
we should keep an reuse the notice in the same way as we do for "final"
There was a problem hiding this comment.
Done. I updated the code base to have consistent messages.
| } | ||
| } | ||
|
|
||
| foreach (call_user_func(function () use ($name, $parent) { |
There was a problem hiding this comment.
can't we make this closure into a method? that'd ease perf and reading
There was a problem hiding this comment.
I just removed it in favor of an array_merge call
| @@ -30,8 +30,7 @@ | |||
| * | |||
| * @see ExecutionContextInterface | |||
| * | |||
| * @internal You should not instantiate or use this class. Code against | |||
| * {@link ExecutionContextInterface} instead. | |||
| * @internal since version 3.5. Code against ExecutionContextInterface instead. | |||
nicolas-grekas
approved these changes
Aug 6, 2017
|
Thank you @GuilhemN. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 7, 2017
…lass/trait/interface (GuilhemN) This PR was squashed before being merged into the 3.4 branch (closes #23807). Discussion ---------- [Debug] Trigger a deprecation when using an internal class/trait/interface | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | not truly <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23800 | License | MIT | Doc PR | Trigger a deprecation when the user uses an internal class/trait/interface. The deprecation is not triggered when an `@internal` is used in the same vendor. Commits ------- b89ba29 [Debug] Trigger a deprecation when using an internal class/trait/interface
|
I merged quickly so you can continue on #23816 (reviewers, if you had any comment here, please comment on this other PR) |
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger a deprecation when the user uses an internal class/trait/interface.
The deprecation is not triggered when an
@internalis used in the same vendor.