Revert "feature #21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)" #23825
Conversation
| @@ -132,8 +126,6 @@ private function warmupCache(InputInterface $input, OutputInterface $output, $re | |||
| * @param string $warmupDir | |||
| * @param string $realCacheDir | |||
| * @param bool $enableOptionalWarmers | |||
| * | |||
| * @internal to be removed in 4.0 | |||
There was a problem hiding this comment.
note that in 3.4, the command class is @final so we can still make them private in 4.0. I'll take care of it when merging up.
34369ad to
9009970
Compare
|
I would not revert this in 3.3 as it helps with Flex. Here is the output right now when doing
As you can see, the warning helps explain the fatal error and provide a way to fix the issue. Instead, I would change the warning to explain that without the |
|
Investigating the issue a bit more, fixing the So, let's remove the |
|
Thank you @nicolas-grekas. |
…clear with warmup (fabpot)" (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- Revert "feature #21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)" This reverts commit 3495b35, reversing changes made to 7f7b897. | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21038 | License | MIT | Doc PR | - Sibling to #23792: there is no need to trigger the deprecation in 3.3 if we un-deprecate in 3.4. Commits ------- 9009970 Revert "feature #21038 [FrameworkBundle] deprecated cache:clear with warmup (fabpot)"
This reverts commit 3495b35, reversing
changes made to 7f7b897.
Sibling to #23792: there is no need to trigger the deprecation in 3.3 if we un-deprecate in 3.4.