[2.8] Modify 2.8 upgrade doc - key option is deprecated. #23826
Conversation
| @@ -546,6 +546,9 @@ Security | |||
|
|
|||
| * The `VoterInterface::supportsClass` and `supportsAttribute` methods were | |||
| deprecated and will be removed from the interface in 3.0. | |||
|
|
|||
| * The the `key` setting of `anonymous`, `remember_me` and `http_digest` | |||
| is deprecated, and will be removed in 3.0. Use `secret` instead. | |||
There was a problem hiding this comment.
Use the `secret` option instead.
Oh wait, the Bundle upgrade guide doesn't mention this :) better to wait for a merge to decide.
There was a problem hiding this comment.
I'm happy to make this change, but I'll wait for someone else to confirm that it's needed, then.
There was a problem hiding this comment.
We should add a config example showing the difference. You can borrow the one from #16493.
There was a problem hiding this comment.
Okaydoke, and thanks for the link. Added in commit 84a6d70 now.
Don't worry, this happens from time to time 👍 |
|
Thanks for the reassuring words about tests, @sstok - that sort of reassurance makes contributing easier for us first-timers! |
Example taken from #16493
| @@ -546,6 +546,95 @@ Security | |||
|
|
|||
| * The `VoterInterface::supportsClass` and `supportsAttribute` methods were | |||
| deprecated and will be removed from the interface in 3.0. | |||
|
|
|||
| * The the `key` setting of `anonymous`, `remember_me` and `http_digest` | |||
|
Thank you @sampart. |
… (sampart) This PR was squashed before being merged into the 2.8 branch (closes #23826). Discussion ---------- [2.8] Modify 2.8 upgrade doc - key option is deprecated. | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no, but this is only a documentation change - I don't think it's my change that has broken them. | Fixed tickets | n/a | License | MIT | Doc PR | n/a The 2.8.0 section of the [CHANGELOG for the Security bundle](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/SecurityBundle/CHANGELOG.md#280) has two items in it > * deprecated the `key` setting of `anonymous`, `remember_me` and `http_digest` in favor of the `secret` setting. > * deprecated the `intention` firewall listener setting in favor of the `csrf_token_id`. The first of these isn't also in the Symfony upgrade guide, but the second is. This PR adds the missing item (deprecated `key` setting) into the Symfony upgrade guide. Commits ------- 2309fd9 [2.8] Modify 2.8 upgrade doc - key option is deprecated.
The 2.8.0 section of the CHANGELOG for the Security bundle has two items in it
The first of these isn't also in the Symfony upgrade guide, but the second is.
This PR adds the missing item (deprecated
keysetting) into the Symfony upgrade guide.