Skip to content

[DebugBundle] Reword an outdated comment about var dumper wiring #23841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2017
Merged

[DebugBundle] Reword an outdated comment about var dumper wiring #23841

merged 1 commit into from
Aug 9, 2017

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets N/A
License MIT
Doc PR N/A

This comment is outdated since #19647, as the default config is now the one used all the way through in HTTP mode, while it's overridden in CLI mode by the DumpListener on console.command event.

@ogizanagi ogizanagi added this to the 2.7 milestone Aug 9, 2017
@ogizanagi ogizanagi changed the title DebugBundle: Reword an outdated comment about var dumper wiring [DebugBundle] Reword an outdated comment about var dumper wiring Aug 9, 2017
@nicolas-grekas
Copy link
Member

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit f876fd9 into symfony:2.7 Aug 9, 2017
nicolas-grekas added a commit that referenced this pull request Aug 9, 2017
@nicolas-grekas
minor #23841 [DebugBundle] Reword an outdated comment about var dumpe…
c951ca6 
…r wiring (ogizanagi)

This PR was merged into the 2.7 branch.

Discussion
----------

[DebugBundle] Reword an outdated comment about var dumper wiring

| Q             | A
| ------------- | ---
| Branch?       | 2.7 <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | no
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

This comment is outdated since #19647, as the default config is now the one used all the way through in HTTP mode, while it's overridden in CLI mode by the `DumpListener` on `console.command` event.

Commits
-------

f876fd9 [DebugBundle] Reword an outdated comment about var dumper wiring
@ogizanagi ogizanagi deleted the minor/2.7/debug_bundle/dumper_related_comment branch August 9, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DebugBundle Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
3 participants
@ogizanagi @nicolas-grekas @carsonbot