Skip to content

restrict and increase version of reflection-docblock #23846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ElectricMaxxx
Copy link
Contributor

@ElectricMaxxx ElectricMaxxx commented Aug 9, 2017

Q A
Branch? 3.1, 3.2, 3.3, master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

I think we should have same behavior on 2.8 and 3.0 but there phpdocumentor/reflection is required and i whanted to avoid conflicts.

Reason:

The version 3.2.0 of phpdocumentor/reflection-docblock is really broken. All Annotations lide @api, means without any bracket, leads to errors like Uninitialized string offset: 0. We in the CMF do not require that bundle directly, but symfony does and so we get braking builds.

@ElectricMaxxx ElectricMaxxx changed the title restrict and increase version restrict and increase version of reflection-docblock Aug 9, 2017
@xabbuh
Copy link
Member

xabbuh commented Aug 10, 2017

We should probably then add such an annotation in the test fixtures and switch back to conflicting entirely with 3.2 (like it was done in #23549) as long as the issue isn't fully fixed.

@xabbuh xabbuh added this to the 3.3 milestone Aug 10, 2017
@ElectricMaxxx
Copy link
Contributor Author

I currently also do not trust the conflict section in composer. I tryed it on symfony-cmf/routing-auto-bundle and it does not restrict. I did exactly get the broken version. So i would go back to the restriction in require section?
What about the failing test on the CI? I does not seem to be related to my change.
What about the bundles/components? Should they get same too?

@xabbuh
Copy link
Member

xabbuh commented Aug 10, 2017

@ElectricMaxxx I would first switch the target branch to 3.3 (3.1 and 3.2 are not supported anymore) and rebase accordingly. That will probably help making tests pass.

The version 3.2.0 and 3.2.1 of reflection-docblock is broken and lower version as 3.1 miss some tags.
@ElectricMaxxx ElectricMaxxx force-pushed the fix_doc_block_version branch from 9df0f39 to 5830d01 Compare August 10, 2017 07:26
@ElectricMaxxx ElectricMaxxx changed the base branch from 3.1 to 3.3 August 10, 2017 07:27
@ElectricMaxxx
Copy link
Contributor Author

My Rebase wasn't fine, so i will retry later.

@ElectricMaxxx
Copy link
Contributor Author

CLOSED in favor of: #23848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants