Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions #23852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Symfony versions
chalasr
approved these changes
Aug 11, 2017
| // transform all $configs values to lower case so tests are case-insensitive and | ||
| // they also work in newer Symfony versions where service IDs are case-sensitive | ||
| array_walk_recursive($configs, function (&$value) { | ||
| $value = is_string($value) ? strtolower($value) : $value; |
There was a problem hiding this comment.
i wouldn't change all values, only $configs[0][2] needs to be lowercased.
|
Thanks Javier. |
chalasr
pushed a commit
that referenced
this pull request
Aug 14, 2017
…re for future Symfony versions (javiereguiluz) This PR was squashed before being merged into the 3.4 branch (closes #23852). Discussion ---------- Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is what @nicolas-grekas [told me to do](#23797 (comment)) to unlock #23797. Commits ------- 9b7750a Made some SecurityBundle tests case-insensitive to prepare for future Symfony versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what @nicolas-grekas told me to do to unlock #23797.