Filtering empty uuids in ORMQueryBuilderLoader. #23853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mlazovla
commented
Aug 10, 2017
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #23808 |
| License | MIT |
| Doc PR | no |
|
Seems good enough. But #23808 (comment) would be the more correct solution. |
|
@mlazovla what's your stand about that "more correct solution"? |
|
Maryo's new solution looks more universal than my PR. But I am not sure if it broke some edge case. |
|
So, should we merge and later on do what @maryo describes? Anyone willing to give it a try? |
javiereguiluz
approved these changes
Sep 11, 2017
There was a problem hiding this comment.
This definitely improves our current code and it looks correct. I'm not sure about the other proposed solution here and even its author mentions some potential problems with PostgreSQL.
fabpot
approved these changes
Sep 11, 2017
|
Thank you @mlazovla. |
fabpot
added a commit
that referenced
this pull request
Sep 11, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Filtering empty uuids in ORMQueryBuilderLoader. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23808 | License | MIT | Doc PR | no Commits ------- 27e8cd2 Filtering empty uuids in ORMQueryBuilderLoader.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.