[DI] Fix resolving env vars when compiling a ContainerBuilder #23940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Aug 21, 2017
| /** | ||
| * Replaces env var placeholders by their current values. | ||
| */ | ||
| class ResolveEnvPlaceholdersPass extends AbstractRecursivePass |
There was a problem hiding this comment.
implementation is similar to the one in ResolveParameterPlaceHoldersPass
| /** | ||
| * Replaces "%env(FOO)%" references by their placeholder, keeping regular "%parameters%" references as is. | ||
| */ | ||
| public function resolveEnvReferences(array $value) |
There was a problem hiding this comment.
Method has been introduced a few days ago, never released yet - thus no BC break here.
30f362d to
32f844f
Compare
32f844f to
a09fb37
Compare
|
@nicolas-grekas i reproduced the array-to-string conversion on 3.3 with That now produces The mixed runtime/compiletime works great now, inlucding leaving out default and/or real values. It just works as expected 👍 |
a09fb37 to
9219594
Compare
fixed, should be good then |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2017
…der (nicolas-grekas) This PR was merged into the 3.3 branch. Discussion ---------- [DI] Fix resolving env vars when compiling a ContainerBuilder | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As spotted by @ro0NL, `$container->compile(true)` doesn't resolve direct env var references found in service definitions. Fixed here. Commits ------- 9219594 [DI] Fix resolving env vars when compiling a ContainerBuilder
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As spotted by @ro0NL,
$container->compile(true)doesn't resolve direct env var references found in service definitions. Fixed here.