[Cache] Use options from Memcached DSN #23978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e85dcab to
264d764
Compare
|
There are needed any work on this PR from me? |
| } | ||
| } | ||
|
|
||
| public function provideDSNWithOptions() |
There was a problem hiding this comment.
should be provideDsnWithOptions
the provider should do a class_exists check on Memcached and yield nothing when not, in order to allow skipping the tests when Memcached is not installed
264d764 to
1363664
Compare
|
@nicolas-grekas fixed. |
fabpot
reviewed
Aug 26, 2017
| @@ -6,6 +6,7 @@ CHANGELOG | |||
|
|
|||
| * added PruneableInterface so PSR-6 or PSR-16 cache implementations can declare support for manual stale cache pruning | |||
| * added FilesystemTrait::prune() and PhpFilesTrait::prune() implementations | |||
| * added Using options from Memcached DSN | |||
1363664 to
7abc4b2
Compare
|
Updated |
| @@ -139,11 +117,34 @@ public static function createConnection($servers, array $options = array()) | |||
| if (isset($params['query'])) { | |||
| parse_str($params['query'], $query); | |||
| $params += $query; | |||
| $options += $query; | |||
There was a problem hiding this comment.
this means that the precedence is:
- options provided as 2nd argument
- win over options provided as part of the DSN
- who then win over defaults.
But in RedisTrait, 1. and 2. are swapped:
- options provided as part of the DSN
- win over options provided as 2nd arg
- who then win over defaults.
This allows "the infrastructure" to take over the app config.
I think it also makes sense to do the same here.
nicolas-grekas
requested changes
Sep 2, 2017
7abc4b2 to
94ad162
Compare
94ad162 to
5798dd6
Compare
|
@nicolas-grekas Fixed. Also updated tests for this case. |
1 task
nicolas-grekas
approved these changes
Sep 5, 2017
fabpot
approved these changes
Sep 5, 2017
|
Thank you @Bukashk0zzz. |
fabpot
added a commit
that referenced
this pull request
Sep 5, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [Cache] Use options from Memcached DSN | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23962 | License | MIT | Doc PR | - This PR allows to pass options in cache config. Example: ```yaml framework: cache: app: cache.adapter.memcached default_memcached_provider: 'memcached://%env(MEMCACHE_HOST)%?socket_recv_size=1&socket_send_size=2' ``` Commits ------- 5798dd6 [Cache] Use options from Memcached DSN
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to pass options in cache config.
Example: