[Cache] Always require symfony/polyfill-apcu to provide APCuIterator everywhere #24011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 28, 2017
|
This updates the |
|
@chalasr : fixed |
|
If we are OK to make Cache requires polyfill-apcu (a bit weird to me since it can be used without apcu), a test case would be nice to prevent future regressions. |
|
@chalasr : symfony/polyfill-apcu is used to provide APCuIterator for both PHP 5.5 + apcu 4.x and PHP 7.0. Will add a test ;) |
|
Test added, but Travis does not report it as the tests are run with the require-dev dependencies, e.g. with symfony/polyfill-apcu. |
|
the root composer file also needs to be patched as you did before |
|
@nicolas-grekas : you mean both composer.json files ? |
|
yes, both need the patch |
nicolas-grekas
approved these changes
Aug 29, 2017
chalasr
approved these changes
Aug 29, 2017
|
Thank you @guillaumelecerf. |
fabpot
added a commit
that referenced
this pull request
Aug 29, 2017
…CuIterator everywhere (guillaumelecerf) This PR was merged into the 3.3 branch. Discussion ---------- [Cache] Always require symfony/polyfill-apcu to provide APCuIterator everywhere | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT **TL;DR: when APCuIterator is not available (i.e. PHP 5.6 + APCu 4.0.7), the APC cache handling is broken.** When [the app initializes](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Resources/config/cache.xml#L31) one of [the APC caches](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Resources/config/cache.xml#L14-L28), it tries to [retrieve its namespace flag key](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Traits/ApcuTrait.php#L42). If it can't, [it clears its namespaced cache](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Traits/ApcuTrait.php#L43) and [adds its flag key back](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Traits/ApcuTrait.php#L44). But [when APCuIterator is not usable](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Traits/ApcuTrait.php#L74), **the app [flushes the whole cache each time](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Cache/Traits/ApcuTrait.php#L76)**, preventing all the APC caches to retrieve their own flag key, resulting in a **perpetual full APC cache flush**. TODO: - [x] add test => https://travis-ci.org/symfony/symfony/jobs/269383629#L3334 See #24008 Commits ------- 9d44442 Always require symfony/polyfill-apcu to provide APCuIterator everywhere
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: when APCuIterator is not available (i.e. PHP 5.6 + APCu 4.0.7), the APC cache handling is broken.
When the app initializes one of the APC caches, it tries to retrieve its namespace flag key. If it can't, it clears its namespaced cache and adds its flag key back.
But when APCuIterator is not usable, the app flushes the whole cache each time, preventing all the APC caches to retrieve their own flag key, resulting in a perpetual full APC cache flush.
TODO:
See #24008